9 May 2022 by Phillip JohnstonCode reviews be focused on identifying defects with the code. However, the reviewer should not provide fixes for the problems – the author is a smart person who can come up with solutions on their own, and they can do so once all feedback is received. If the author would like input on how to address the defect, they are free to ask. References Code Review Guidelines A Guide to Code Inspections by Jack Ganssle During the meeting we don’t invent fixes for problems. The author is a smart person we respect who will come …
Continue reading “Find Problems During the Review – But Don’t Fix Them”
